Skip to content

Conversation

@apanasenko-oai
Copy link
Collaborator

No description provided.

@apanasenko-oai apanasenko-oai force-pushed the anton_panasneko_resume_from_history branch 2 times, most recently from 4a1cee2 to 0202c95 Compare October 29, 2025 00:30
Copy link
Collaborator

@aibrahim-oai aibrahim-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a new request with its own tests to have less complexity

@@ -499,12 +499,15 @@ pub struct LogoutAccountResponse {}
#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)]
#[serde(rename_all = "camelCase")]
pub struct ResumeConversationParams {
/// Absolute path to the rollout JSONL file. If omitted, `conversationId` must be provided.
/// Absolute path to the rollout JSONL file, when explicitly resuming a known rollout.
#[serde(skip_serializing_if = "Option::is_none")]
pub path: Option<PathBuf>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have a separate request for it. This current approach makes it possible to send a request without path or history.

@apanasenko-oai apanasenko-oai force-pushed the anton_panasneko_resume_from_history branch from 0202c95 to e5a237c Compare October 29, 2025 00:57
@apanasenko-oai apanasenko-oai merged commit 149e198 into main Oct 29, 2025
25 checks passed
@apanasenko-oai apanasenko-oai deleted the anton_panasneko_resume_from_history branch October 29, 2025 01:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants