templates and build step for validating/submitting winget package #6485
+149
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
reviewed
Nov 12, 2025
codex-rs/cli/packaging/winget/template/OpenAI.Codex.installer.yaml
Outdated
Show resolved
Hide resolved
bolinfest
approved these changes
Nov 13, 2025
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Thanks for doing this!
| shell: bash | ||
| continue-on-error: true | ||
| run: | | ||
| set -euo pipefail |
Collaborator
There was a problem hiding this comment.
FYI, I think GitHub sets this for shell: bash.
| -X PATCH \ | ||
| -f sha="${GITHUB_SHA}" \ | ||
| -F force=true | ||
| -F force=true |
| @@ -0,0 +1,36 @@ | |||
| WinGet manifests for the Codex CLI | |||
Collaborator
There was a problem hiding this comment.
How about we make this .github/workflows/winget.md instead?
bolinfest
reviewed
Nov 13, 2025
| id: win_hash | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail |
Contributor
Author
|
gonna land this since @bolinfest is on PTO. Will follow-up with some fixes from the comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.