Skip to content

Conversation

@celia-oai
Copy link
Contributor

@celia-oai celia-oai commented Nov 12, 2025

core event to app server event mapping:

  1. codex/event/reasoning_content_delta -> item/reasoning/summaryTextDelta.
  2. codex/event/reasoning_raw_content_delta -> item/reasoning/textDelta
  3. codex/event/agent_message_content_deltaitem/agentMessage/delta.
  4. codex/event/agent_reasoning_section_break -> item/reasoning/summaryPartAdded.

Also added a change in core to pass down content index, summary index and item id from events.

Tested with the git checkout owen/app_server_test_client && cargo run -p codex-app-server-test-client -- send-message-v2 "hello" and verified that new events are emitted correctly.

@celia-oai celia-oai changed the title [Draft] [Draft][App-server] add item/reasoning/delta and item/agentMessage/delta Nov 12, 2025
@etraut-openai etraut-openai added the oai-pr PRs posted by Codex team members label Nov 12, 2025
@celia-oai celia-oai changed the title [Draft][App-server] add item/reasoning/delta and item/agentMessage/delta [Draft][App-server] add new v2 events:item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded Nov 12, 2025
@celia-oai celia-oai marked this pull request as ready for review November 12, 2025 23:59
@celia-oai celia-oai changed the title [Draft][App-server] add new v2 events:item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded [App-server] add new v2 events:item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded Nov 13, 2025
@celia-oai celia-oai force-pushed the dev/cc/add-item-2 branch 12 times, most recently from 55c2a16 to f26660f Compare November 13, 2025 19:54
@celia-oai celia-oai requested a review from owenlin0 November 13, 2025 19:55
@celia-oai celia-oai force-pushed the dev/cc/add-item-2 branch 5 times, most recently from a0b1805 to 1cfef9d Compare November 13, 2025 20:21
Copy link
Contributor

@owenlin0 owenlin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)]
#[serde(rename_all = "camelCase")]
#[ts(export_to = "v2/")]
pub struct ReasoningSummaryPartAddedNotification {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a ReasoningContentPartAddedNotification too? since ThreadItem has both summary and content vectors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason for this is explained in this thread!

@celia-oai celia-oai force-pushed the dev/cc/add-item-2 branch 4 times, most recently from b35020b to e8c7642 Compare November 13, 2025 22:35
@celia-oai celia-oai enabled auto-merge (squash) November 13, 2025 23:45
@celia-oai celia-oai merged commit b8ec97c into main Nov 14, 2025
44 of 46 checks passed
@celia-oai celia-oai deleted the dev/cc/add-item-2 branch November 14, 2025 00:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

oai-pr PRs posted by Codex team members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants