-
Notifications
You must be signed in to change notification settings - Fork 6.4k
[App-server] add new v2 events:item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
#6559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
item/reasoning/delta and item/agentMessage/delta
item/reasoning/delta and item/agentMessage/deltaitem/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAddeditem/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
55c2a16 to
f26660f
Compare
a0b1805 to
1cfef9d
Compare
owenlin0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)] | ||
| #[serde(rename_all = "camelCase")] | ||
| #[ts(export_to = "v2/")] | ||
| pub struct ReasoningSummaryPartAddedNotification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a ReasoningContentPartAddedNotification too? since ThreadItem has both summary and content vectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason for this is explained in this thread!
b35020b to
e8c7642
Compare
e8c7642 to
64f4b66
Compare
e4ba191 to
03c6d30
Compare
core event to app server event mapping:
codex/event/reasoning_content_delta->item/reasoning/summaryTextDelta.codex/event/reasoning_raw_content_delta->item/reasoning/textDeltacodex/event/agent_message_content_delta→item/agentMessage/delta.codex/event/agent_reasoning_section_break->item/reasoning/summaryPartAdded.Also added a change in core to pass down content index, summary index and item id from events.
Tested with the
git checkout owen/app_server_test_client && cargo run -p codex-app-server-test-client -- send-message-v2 "hello"and verified that new events are emitted correctly.