-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Close stale PRs workflow #6594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close stale PRs workflow #6594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const dryRun = true; | ||
| const stalePrs = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hard-coded dry run flag
The workflow is supposed to close stale contributor PRs, but const dryRun = true; means the loop later always hits the dry-run branch (if (dryRun) { … continue; }) and never executes the comment/close calls. As a result the scheduled job will only log “Would close …” and never actually close anything, so the automation described in the commit message is completely non-functional until the flag is flipped or made configurable.
Useful? React with 👍 / 👎.
etraut-openai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. It looks good to me, but I think it's worth considering extending from 7 to 14 days.
Closes stale PRs from OpenAI employees.