Skip to content

Conversation

@pakrym-oai
Copy link
Collaborator

@pakrym-oai pakrym-oai commented Nov 13, 2025

Makes output easier to parse

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 295 to 299
"content": [{ "type": "input_text", "text": "resumed user message" }]
},
{
"type": "message",
"type": "message1",
"role": "assistant",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep expected message type unchanged

In resume_includes_initial_messages_and_sends_prior_items the expected request body now looks for an assistant item with "type": "message1", but the client code always serializes both user and assistant conversation items with "type": "message" (there is no message1 variant anywhere in the API). This typo makes the assertion fail on every run, so the test suite can no longer pass and the regression the test guards is no longer exercised.

Useful? React with 👍 / 👎.

Copy link
Collaborator

@zhao-oai zhao-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pakrym-oai pakrym-oai enabled auto-merge (squash) November 13, 2025 21:27
@pakrym-oai pakrym-oai disabled auto-merge November 13, 2025 21:50
@pakrym-oai pakrym-oai merged commit 547be54 into main Nov 13, 2025
24 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/only-list-failed-tests branch November 13, 2025 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants