tests: replace mount_sse_once_match with mount_sse_once for SSE mocking #6640
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let first_response = sse(vec![ev_response_created("resp-1"), ev_completed("resp-1")]); | ||
| mount_sse_once_match(&server, any(), first_response).await; | ||
| mount_sse_once(&server, first_response).await; | ||
|
|
There was a problem hiding this comment.
This file now calls mount_sse_once directly, but the only import that was left in place is use core_test_support::responses::mount_sse_once_match;. Because the symbol is neither imported nor referenced through the responses:: module, the code no longer compiles—the compiler raises cannot find function mount_sse_once in this scope the moment this line is compiled. Bring mount_sse_once into scope (or qualify the call) wherever you replaced the matcher.
Useful? React with 👍 / 👎.
… unused imports Standardize on mount_sse_once in test suites instead of mount_sse_once_match(any(), ...), simplifying mock setup. Update AGENTS.md to advise using mount_sse_once by default. Remove unnecessary wiremock::matchers::any imports where no longer needed. Also fix call in tools.rs to use submit_turn_with_policies.
pakrym-oai
force-pushed
the
pakrym/prefer-mount-sse-once
branch
from
e5f2966 to
25d3d97
Compare
Remove useless mount_sse_once_match