-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Fix FreeBSD/OpenBSD builds: target-specific keyring features and BSD hardening #6680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hardening - Disable keyring default-features at workspace root - Scope keyring native backends via target cfgs in core, keyring-store, rmcp-client - linux: linux-native-async-persistent - macOS: apple-native - windows: windows-native - freebsd/openbsd: sync-secret-service - Add pre_main_hardening_bsd (RLIMIT_CORE=0, clear LD_*) - Simplify process-hardening deps to unconditional libc - Keep non-Linux platforms free of linux-only features to avoid build failures
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for the contribution! Looks like CI is failing due to linter issues (cargo clippy). Please fix those. |
celia-oai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed a small bug of dependency but otherwise looks good. thanks for fixing it!
|
@jxy, the change is approved. Once you fix the lint (cargo clippy) errors, it should be ready to merge. |
@etraut-openai seems that the tests are failing on a sccache issue for windows unrelated to this change. I'm digging around a bit to see if we can unblock here. seems that updating the branch with this fix should just work: #6751. just merged the latest master in. |
Summary
Builds on FreeBSD and OpenBSD were failing due to globally enabled Linux-specific keyring features and hardening code paths not gated by OS. This PR scopes keyring native backends to the
appropriate targets, disables default features at the workspace root, and adds a BSD-specific hardening function. Linux/macOS/Windows behavior remains unchanged, while FreeBSD/OpenBSD
now build and run with a supported backend.
Key Changes
Rationale
Impact by Platform
Testing
Risks / Compatibility
Reviewer Notes
Checklist