Fix AltGr/backslash input on Windows Codex terminal #6720
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Akrelion45
force-pushed
the
fix-altgr-literal-char
branch
2 times, most recently
from
e9766e3 to
11e4ac9
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.insert_str(&c.to_string()); | ||
| } |
There was a problem hiding this comment.
The new Ctrl+Alt branch in TextArea::input is missing a trailing comma after the closing }. Because more match arms follow, Rust requires that comma, so the crate will no longer compile after this commit. Please add the comma after the block so the code builds again.
Useful? React with 👍 / 👎.
|
Thanks for the contribution. Please fix the syntax error (missing comma). |
Akrelion45
force-pushed
the
fix-altgr-literal-char
branch
from
11e4ac9 to
9c09031
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
This bug was at the top of my list to investigate this week, but you beat me to it. This fix is going to make a lot of codex users happy! Thanks again for the contribution. |
2 participants
Summary
backslash and other characters via AltGr insert correctly.
advance the cursor.
Motivation
On US/UK keyboard layouts, backslash is produced by a plain key, so Ctrl+Alt handling is never exercised and the
bug isn’t visible. On many non‑US layouts (e.g., German), backslash and other symbols require AltGr, which terminals
report as Ctrl+Alt+. Our textarea previously filtered these chords like navigation bindings, so AltGr input was
dropped on affected layouts. This change treats AltGr chords as literal input so backslash and similar symbols work on
Windows terminals.
This fixes multiple reported Issues where the \ symbol got cut off. Like:
C:\Users\Admin
became
C:UsersAdmin