tmp: drop sccache for windows 2 #6775
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/rust-ci.yml
Outdated
| RUSTC_WRAPPER: sccache | ||
| # Speed up repeated builds across CI runs by caching compiled objects (non-Windows). | ||
| USE_SCCACHE: ${{ startsWith(matrix.runner, 'windows') && 'false' || 'true' }} | ||
| RUSTC_WRAPPER: ${{ startsWith(matrix.runner, 'windows') && '' || 'sccache' }} |
There was a problem hiding this comment.
With this change we always define RUSTC_WRAPPER, and on Windows we set it to the empty string. Cargo still tries to spawn whatever RUSTC_WRAPPER points to, so an empty value makes every Windows compile fail immediately with “failed to execute "": The filename, directory name, or volume label syntax is incorrect.” To actually disable sccache on Windows we need to stop exporting the variable there rather than set it to empty.
Useful? React with 👍 / 👎.
No description provided.