Skip to content

Conversation

@celia-oai
Copy link
Contributor

@celia-oai celia-oai commented Nov 17, 2025

similar to logic in codex/codex-rs/exec/src/event_processor_with_jsonl_output.rs. translation of v1 -> v2 events:
codex/event/task_complete -> turn/completed
codex/event/turn_aborted -> turn/completed with interrupted status
codex/event/error -> turn/completed with error status

this PR also makes items field in Turn optional. For now, we only populate it when we resume a thread, and leave it as None for all other places until we properly rewrite core to keep track of items.

tested using the codex app server client. example new event:

< {
<   "method": "turn/completed",
<   "params": {
<     "turn": {
<       "id": "0",
<       "items": [],
<       "status": "interrupted"
<     }
<   }
< }

@celia-oai celia-oai force-pushed the dev/cc/experiments branch 7 times, most recently from 2416dbf to 32a057d Compare November 18, 2025 02:02
@celia-oai celia-oai changed the title [draft] [app-server] introduce turn/completed v2 event Nov 18, 2025
@celia-oai celia-oai marked this pull request as ready for review November 18, 2025 02:09
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@celia-oai celia-oai force-pushed the dev/cc/experiments branch 10 times, most recently from e274b67 to 7e4428d Compare November 18, 2025 22:14
@celia-oai celia-oai force-pushed the dev/cc/experiments branch 5 times, most recently from 9e3d49d to e1b831e Compare November 18, 2025 22:55
@celia-oai celia-oai force-pushed the dev/cc/experiments branch 4 times, most recently from b7b3fa7 to 54143ab Compare November 18, 2025 23:19
@celia-oai celia-oai requested a review from bolinfest November 18, 2025 23:22
Copy link
Contributor

@owenlin0 owenlin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt overall! can we update the turn_start.rs and turn_interrupt.rs tests to check turn/completed?

@celia-oai celia-oai force-pushed the dev/cc/experiments branch 4 times, most recently from b644323 to 7c47723 Compare November 19, 2025 01:09
@celia-oai celia-oai requested a review from bolinfest November 19, 2025 01:15
@celia-oai celia-oai enabled auto-merge (squash) November 19, 2025 01:43
@celia-oai celia-oai merged commit b395dc1 into main Nov 19, 2025
25 checks passed
@celia-oai celia-oai deleted the dev/cc/experiments branch November 19, 2025 01:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants