-
Notifications
You must be signed in to change notification settings - Fork 6.4k
[app-server] introduce turn/completed v2 event
#6800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2416dbf to
32a057d
Compare
32a057d to
321c33c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e274b67 to
7e4428d
Compare
9e3d49d to
e1b831e
Compare
b7b3fa7 to
54143ab
Compare
54143ab to
7bbee29
Compare
owenlin0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt overall! can we update the turn_start.rs and turn_interrupt.rs tests to check turn/completed?
b644323 to
7c47723
Compare
7c47723 to
8db5394
Compare
similar to logic in
codex/codex-rs/exec/src/event_processor_with_jsonl_output.rs. translation of v1 -> v2 events:codex/event/task_complete->turn/completedcodex/event/turn_aborted->turn/completedwithinterruptedstatuscodex/event/error->turn/completedwitherrorstatusthis PR also makes
itemsfield inTurnoptional. For now, we only populate it when we resume a thread, and leave it as None for all other places until we properly rewrite core to keep track of items.tested using the codex app server client. example new event: