Skip to content

Conversation

@iceweasel-oai
Copy link
Contributor

No description provided.

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/openai/codex/blob/8542bfd65309a65ea194fe20d41b9058bfad03de/windows-sandbox-rs/sandbox_smoketests.py#L441-L458
P1 Badge Restore .ssh case-variation smoke test

By replacing the old .SsH case-variation smoke test with the new Start-Process check we no longer exercise whether .ssh remains protected against case tricks. The allowlist logic is scoped per path, so the existing .GiT case test does not tell us anything about .ssh: if the sandbox still mishandles .SsH (which was the whole reason for the prior test), that regression will now go unnoticed. Given that .ssh contains private keys, losing this coverage leaves a high-value escape untracked. Please keep the .ssh variation test in addition to the new browser-launch scenario so we continue to catch that failure.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@iceweasel-oai iceweasel-oai merged commit b952bd2 into main Nov 19, 2025
25 checks passed
@iceweasel-oai iceweasel-oai deleted the dev/iceweasel/windows-sandbox-security-doc branch November 19, 2025 00:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants