Skip to content

Conversation

@aibrahim-oai
Copy link
Collaborator

it got serialized wrong.

@aibrahim-oai aibrahim-oai enabled auto-merge (squash) November 20, 2025 01:00
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 110 to 112
HIDE_GPT_5_1_CODEX_MAX_MIGRATION_PROMPT_CONFIG => {
error!("migration_prompt_hidden: {:?}", config.notices);
config.notices.hide_gpt_5_1_codex_max_migration_prompt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove spurious error! log

Calling error!("migration_prompt_hidden: …") here fires on every normal invocation of migration_prompt_hidden for the gpt-5.1-codex-max flag. That code path runs on startup even when the config is healthy, so this change will emit an error-level log every session despite nothing being wrong. It will pollute production error monitoring and make it look like the app is continually failing. Please drop this log or demote it to a debug-level statement before landing.

Useful? React with 👍 / 👎.

@pakrym-oai pakrym-oai disabled auto-merge November 20, 2025 01:16
@pakrym-oai pakrym-oai merged commit 6d67b8b into main Nov 20, 2025
22 of 25 checks passed
@pakrym-oai pakrym-oai deleted the stop-model-migration branch November 20, 2025 01:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants