Skip to content

fix: prevent race condition in listener iteration #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

fix: prevent race condition in listener iteration #1956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/agents/realtime/openai_realtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ def remove_listener(self, listener: RealtimeModelListener) -> None:

async def _emit_event(self, event: RealtimeModelEvent) -> None:
"""Emit an event to the listeners."""
for listener in self._listeners:
# Copy list to avoid modification during iteration
for listener in list(self._listeners):
await listener.on_event(event)

async def _listen_for_messages(self):
Expand Down