Fix #1846 Litellm: fails with function name for tool_choice parameter w/ streaming enabled #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihower
force-pushed
the
fix-litellm-streaming-tool-choice
branch
from
a54b752 to
0da5b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1846
This PR provides a simpler fix than #1929.
The root cause is the same as in #1206
When returning the final
Response, it should be converted to the Responses API format.Applying the exactly same fix from PR #1206 (by @seratch) resolves this issue.
No new tests were added, since
Converter.convert_tool_choiceis already tested.