fix: #1942 Enable async tool calling in Realtime sessions #1984
+117
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
commented
Oct 23, 2025
|
|
||
| self._guardrail_tasks: set[asyncio.Task[Any]] = set() | ||
| self._tool_call_tasks: set[asyncio.Task[Any]] = set() | ||
| self._async_tool_calls: bool = bool(self._run_config.get("async_tool_calls", True)) |
There was a problem hiding this comment.
As I mentioned in the PR description, the default value is true. If we'd like to make this opt-in, we can change this part for it, and switch the default behavior to true in future minor/major versions. But I personally think setting true should be beneficial for everyone.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
force-pushed
the
issue-1942-async-function-calls
branch
from
ffd4c09 to
8f37010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1942 and the new behavior aligns with TS SDK. I think this is a kind of behavioral bug for most use cases, so I've switched the default behavior to this new one by default. If a developer wants to switch back to the current behavior, they can customize this way. That said, I cannot think of those use cases: