Fix DI example in README.md #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilsquirr3l
requested review from
ShivangiReja,
joseharriaga and
trrwilson
as code owners
ShivangiReja
approved these changes
Aug 1, 2025
Collaborator
ShivangiReja
left a comment
ShivangiReja
left a comment
There was a problem hiding this comment.
Thanks for the contribution! You're absolutely right that the model needs to be provided. Really appreciate you taking the time to fix the README!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small error in README.md:
ChatClientdoesn't have a constructor with only one parameter, and you must always provide a model as the first param.