Skip to content

Conversation

@kurnakovv
Copy link
Contributor

Copy link
Collaborator

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @kurnakovv!

This PR modifies generated code. Instead, it should modify the TypeSpec spec that defines the ReasoningEffort type.

That said, there is an updated spec in the works that already includes this value, so this change will show up as soon as we incorporate the new spec and regenerate.

@jsquire
Copy link
Collaborator

jsquire commented Sep 11, 2025

Hi @kurnakovv. As Chris mentioned here and I detailed in the associated issue, the value must be added to the REST API specification in order for it to appear in the client. While we maintain a local copy of the spec in the repository, the official version is authored upstream and then flows to us. Anything that is changed in the local spec or the C# code generated from it will be overwritten when the official spec is next released.

Since we're unable to move forward with this contribution, I'm going to close out the PR. Thank you, again, for your contribution and interested in improving the OpenAI developer experience.

@jsquire jsquire closed this Sep 11, 2025
@kurnakovv
Copy link
Contributor Author

@christothes @jsquire

That said, there is an updated spec in the works that already includes this value, so this change will show up as soon as we incorporate the new spec and regenerate.

Thank you very much for your answer, and could you tell me where I can look at this? I just don't quite understand where it changes (I didn't find a branch/PR with changes)
Or is it that it changes in a different way?

If anything, then I am ready to change the code that you indicated in the link (but most likely not, because you said that the code has already changed somewhere)

@christothes
Copy link
Collaborator

The place I linked is correct, however we are in the process updating a private version of the spec which should be published soon. In the meantime, if you are curious about the process for updating the spec, you could add the new minimal value to the type I linked and then run the Invoke-CodeGen script.

kurnakovv added a commit to kurnakovv/openai-dotnet that referenced this pull request Sep 26, 2025
kurnakovv added a commit to kurnakovv/openai-dotnet that referenced this pull request Sep 26, 2025
kurnakovv added a commit to kurnakovv/openai-dotnet that referenced this pull request Sep 27, 2025
jsquire added a commit that referenced this pull request Sep 28, 2025
* Add ReasoningEffort.minimal value (#673)

* Update api files (#675)

* Add ReasoningEffortLevel.Minimal to CHANGELOG (#675)

* Update CHANGELOG.md

---------

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants