Skip to content

Add OpenAIResponseClient.GetResponse{Streaming}Async overloads that take RequestOptions #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

Add OpenAIResponseClient.GetResponse{Streaming}Async overloads that take RequestOptions #753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5136061
add internal overloads for GetResponse{Streaming}Async methods
SergeyMenshykh Oct 11, 2025
e9c7dc1
remove async from internal GetResponseStreaming
SergeyMenshykh Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/Custom/Responses/OpenAIResponseClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,21 @@ public virtual CollectionResult<StreamingResponseUpdate> CreateResponseStreaming
cancellationToken);
}

public virtual async Task<ClientResult<OpenAIResponse>> GetResponseAsync(string responseId, CancellationToken cancellationToken = default)
public virtual Task<ClientResult<OpenAIResponse>> GetResponseAsync(string responseId, CancellationToken cancellationToken = default)
{
return GetResponseAsync(responseId, cancellationToken.ToRequestOptions() ?? new RequestOptions());
}

internal async Task<ClientResult<OpenAIResponse>> GetResponseAsync(string responseId, RequestOptions requestOptions)
{
Argument.AssertNotNullOrEmpty(responseId, nameof(responseId));
Argument.AssertNotNull(requestOptions, nameof(requestOptions));
if (requestOptions.BufferResponse is false)
{
throw new InvalidOperationException("'requestOptions.BufferResponse' must be 'true' when calling 'GetResponseAsync'.");
}

ClientResult protocolResult = await GetResponseAsync(responseId, stream: null, startingAfter: null, cancellationToken.ToRequestOptions()).ConfigureAwait(false);
ClientResult protocolResult = await GetResponseAsync(responseId, stream: null, startingAfter: null, requestOptions).ConfigureAwait(false);
OpenAIResponse convenienceResult = (OpenAIResponse)protocolResult;
return ClientResult.FromValue(convenienceResult, protocolResult.GetRawResponse());
}
Expand All @@ -247,13 +257,23 @@ public virtual ClientResult<OpenAIResponse> GetResponse(string responseId, Cance
}

public virtual AsyncCollectionResult<StreamingResponseUpdate> GetResponseStreamingAsync(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default)
{
return GetResponseStreamingAsync(responseId, cancellationToken.ToRequestOptions(streaming: true), startingAfter);
}

internal AsyncCollectionResult<StreamingResponseUpdate> GetResponseStreamingAsync(string responseId, RequestOptions requestOptions, int? startingAfter = null)
{
Argument.AssertNotNull(responseId, nameof(responseId));
Argument.AssertNotNull(requestOptions, nameof(requestOptions));
if (requestOptions.BufferResponse is true)
{
throw new InvalidOperationException("'requestOptions.BufferResponse' must be 'false' when calling 'GetResponseStreamingAsync'.");
}

return new AsyncSseUpdateCollection<StreamingResponseUpdate>(
async () => await GetResponseAsync(responseId, stream: true, startingAfter, cancellationToken.ToRequestOptions(streaming: true)).ConfigureAwait(false),
async () => await GetResponseAsync(responseId, stream: true, startingAfter, requestOptions).ConfigureAwait(false),
StreamingResponseUpdate.DeserializeStreamingResponseUpdate,
cancellationToken);
requestOptions.CancellationToken);
}

public virtual CollectionResult<StreamingResponseUpdate> GetResponseStreaming(string responseId, int? startingAfter = null, CancellationToken cancellationToken = default)
Expand Down