Agent parse conversation history #36
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GuardrailAgent to properly parse conversation history and extract the user's last message as a string, fixing an error when using the moderation endpoint (which expects string input rather than complex message structures).
Key Changes:
- Replaces
ContentUtils.extractTextFromMessagewith new custom text extraction functions that handle nested conversation structures - Adds three new helper functions to recursively extract text from various input formats (content parts, message entries, and agent inputs)
- Includes a new test case validating that conversation history is correctly parsed and the latest user message is extracted
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/agents.ts | Removes unused imports and adds new text extraction functions (extractTextFromContentParts, extractTextFromMessageEntry, extractTextFromAgentInput) to handle conversation history parsing; refactors resolveInputText to use the new extraction logic |
| src/tests/unit/agents.test.ts | Fixes indentation in existing test and adds new test case to verify conversation history parsing with multi-part user messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return record.text.trim(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
[nitpick] The inline comment explains the parameter but doesn't clarify when this fallback path is reached. Consider adding a brief comment above this line explaining that this is a last-resort extraction attempt for object structures that don't match standard message patterns.
| // Last-resort extraction: if entry does not match standard message patterns, | |
| // attempt to extract text from any value type. |
Update Agents to properly parse the conversation history for the user's last message