Update SWIFT PII detection #37
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines BIC/SWIFT code detection to reduce false positives by replacing a generic pattern with two targeted approaches: context-aware detection requiring explicit keywords (like "BIC", "SWIFT", "bank code") preceding the code, and pattern matching against a curated list of known bank prefixes from major financial institutions worldwide.
- Replaced overly permissive regex that matched any 8-11 character alphanumeric sequence with specific detection strategies
- Added context-aware pattern requiring banking-related keywords before BIC codes
- Added whitelist of 63 known bank BIC prefixes for standalone code detection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/checks/pii.ts | Implements new BIC/SWIFT detection with context patterns and known prefix list |
| src/tests/unit/checks/pii.test.ts | Updates existing test and adds new tests for context-aware detection, known prefixes, and false positive prevention |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'ICBK', | ||
| 'ABOC', | ||
| 'PCBC', | ||
| 'HSBC', |
There was a problem hiding this comment.
The prefix 'HSBC' appears twice in the KNOWN_BIC_PREFIXES array (lines 225 and 269). Remove the duplicate entry to avoid redundancy.
| 'HSBC', |
| 'IBKO', | ||
| 'KODB', | ||
| 'HNBN', | ||
| 'CITI', |
There was a problem hiding this comment.
The prefix 'CITI' appears twice in the KNOWN_BIC_PREFIXES array (lines 227 and 282). Remove the duplicate entry to avoid redundancy.
| 'CITI', |
Updated
BIC_SWIFTdetection to be more specific reducing false positives