Skip to content

Conversation

@daquexian
Copy link

A simple patch that prevent developers (specially in China) getting confused when switching from sync apis to async apis

@RobertCraigie RobertCraigie added the fixed in v1 Issues addressed by the v1 beta label Nov 6, 2023
@RobertCraigie
Copy link
Collaborator

Thanks for putting the effort into opening a PR, sorry it wasn't merged!

In the v1 of this library we've unified the sync and async clients to use httpx which means there won't be any confusion due to differences in configuration.

stainless-app bot pushed a commit that referenced this pull request Mar 27, 2025
safa0 pushed a commit to safa0/openai-agents-python that referenced this pull request Apr 27, 2025
I fixed the type annotations errors for pydantic objects in some
examples as noted in openai#490 .

When running `make lint` the following error occurs "UP007 Use `X | Y`
for type annotations". If you know how to ignore it I will be happy to
edit the pull request, thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed in v1 Issues addressed by the v1 beta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants