Image create request timeout #618
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It's currently not possible to pass
request_timeouttoImage.create, which prevents setting request timeouts.Reference:
@raiyanyahya has raised this as a concern in #221
According to requests#Timeouts
However, this library has set the default as 600 seconds, which is not practical for many use cases.
User impact:
Occasionally the Image.create API call can stall for 600s, which could be a long time to a user to wait before retrying. By allowing the user to set a reasonable request_timeout, we can retry sooner.
Usage:
Example usage:
Example connect/read timeout usage:
Example async usage: