Skip to content

chore: mark non-inheritable SDK internal classes as final #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025
Merged

chore: mark non-inheritable SDK internal classes as final #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 32 additions & 24 deletions rbi/lib/openai/base_model.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,28 +83,29 @@ module OpenAI
extend OpenAI::Converter

abstract!
final!

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def self.===(other)
end

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def self.==(other)
end

class << self
# @api private
sig { override.params(value: T.anything).returns(T.anything) }
sig(:final) { override.params(value: T.anything).returns(T.anything) }
def coerce(value)
end

# @api private
sig { override.params(value: T.anything).returns(T.anything) }
sig(:final) { override.params(value: T.anything).returns(T.anything) }
def dump(value)
end

# @api private
sig do
sig(:final) do
override
.params(value: T.anything)
.returns(T.any([T::Boolean, T.anything, NilClass], [T::Boolean, T::Boolean, Integer]))
Expand All @@ -119,28 +120,33 @@ module OpenAI
extend OpenAI::Converter

abstract!
final!

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def self.===(other)
end

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def self.==(other)
end

class << self
# @api private
sig { override.params(value: T.any(T::Boolean, T.anything)).returns(T.any(T::Boolean, T.anything)) }
sig(:final) do
override.params(value: T.any(T::Boolean, T.anything)).returns(T.any(T::Boolean, T.anything))
end
def coerce(value)
end

# @api private
sig { override.params(value: T.any(T::Boolean, T.anything)).returns(T.any(T::Boolean, T.anything)) }
sig(:final) do
override.params(value: T.any(T::Boolean, T.anything)).returns(T.any(T::Boolean, T.anything))
end
def dump(value)
end

# @api private
sig do
sig(:final) do
override
.params(value: T.anything)
.returns(T.any([T::Boolean, T.anything, NilClass], [T::Boolean, T::Boolean, Integer]))
Expand Down Expand Up @@ -298,17 +304,18 @@ module OpenAI
include OpenAI::Converter

abstract!
final!

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def ===(other)
end

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def ==(other)
end

# @api private
sig do
sig(:final) do
override
.params(value: T.any(T::Enumerable[T.anything], T.anything))
.returns(T.any(T::Array[T.anything], T.anything))
Expand All @@ -317,7 +324,7 @@ module OpenAI
end

# @api private
sig do
sig(:final) do
override
.params(value: T.any(T::Enumerable[T.anything], T.anything))
.returns(T.any(T::Array[T.anything], T.anything))
Expand All @@ -326,7 +333,7 @@ module OpenAI
end

# @api private
sig do
sig(:final) do
override
.params(value: T.anything)
.returns(T.any([T::Boolean, T.anything, NilClass], [T::Boolean, T::Boolean, Integer]))
Expand All @@ -335,12 +342,12 @@ module OpenAI
end

# @api private
sig { returns(OpenAI::Converter::Input) }
sig(:final) { returns(OpenAI::Converter::Input) }
protected def item_type
end

# @api private
sig do
sig(:final) do
params(
type_info: T.any(
T::Hash[Symbol, T.anything],
Expand All @@ -360,17 +367,18 @@ module OpenAI
include OpenAI::Converter

abstract!
final!

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def ===(other)
end

sig { params(other: T.anything).returns(T::Boolean) }
sig(:final) { params(other: T.anything).returns(T::Boolean) }
def ==(other)
end

# @api private
sig do
sig(:final) do
override
.params(value: T.any(T::Hash[T.anything, T.anything], T.anything))
.returns(T.any(T::Hash[Symbol, T.anything], T.anything))
Expand All @@ -379,7 +387,7 @@ module OpenAI
end

# @api private
sig do
sig(:final) do
override
.params(value: T.any(T::Hash[T.anything, T.anything], T.anything))
.returns(T.any(T::Hash[Symbol, T.anything], T.anything))
Expand All @@ -388,7 +396,7 @@ module OpenAI
end

# @api private
sig do
sig(:final) do
override
.params(value: T.anything)
.returns(T.any([T::Boolean, T.anything, NilClass], [T::Boolean, T::Boolean, Integer]))
Expand All @@ -397,12 +405,12 @@ module OpenAI
end

# @api private
sig { returns(OpenAI::Converter::Input) }
sig(:final) { returns(OpenAI::Converter::Input) }
protected def item_type
end

# @api private
sig do
sig(:final) do
params(
type_info: T.any(
T::Hash[Symbol, T.anything],
Expand Down