Skip to content

add PVC and configmaps support to kubernetes backend#11

Closed
insatomcat wants to merge 1 commit intoopenanalytics:developfrom
insatomcat:kubernetes_pvc_configmaps
Closed

add PVC and configmaps support to kubernetes backend#11
insatomcat wants to merge 1 commit intoopenanalytics:developfrom
insatomcat:kubernetes_pvc_configmaps

Conversation

@insatomcat
Copy link
Copy Markdown

@insatomcat insatomcat commented Dec 5, 2018

Following #5 and #6, new try to add PVC and configmaps features to kubernetes backend.

It could be used that way in shinyproxy :

      - id: app1
        display-name: app1
        description: kubeapp...
        container-image: gcr.io/$PROJECT/blabla:latest
        container-cmd: ["R", "-e","shiny::runApp('.', port = 3838, host = '0.0.0.0')"]
        container-volumes: ["claim_pvcname:/data", "configmap_nameofconfigmap:/app/config/"]

@LEDfan LEDfan added this to the Next milestone Sep 30, 2020
LEDfan pushed a commit that referenced this pull request Oct 12, 2020
@LEDfan
Copy link
Copy Markdown
Member

LEDfan commented Oct 12, 2020

Hi @insatomcat

Thank you for your PR!
In order to not have to implement every Kubernetes feature in ContainerProxy, we decided to add a generic way of adding Kubernetes specific configuration to a ContainerProxy app. This feature is called kubernetes-pod-patches and allows to patch the specification of the Pod before it is created by ContainerProxy.
More information about this feature can be found here (you have to scroll down a bit).
This should cover your use-case. Feel free to open an issue if you experience any issue with this feature.
The change is included in the just ShinyProxy 2.4.0

Again thanks for your contribution.

@LEDfan LEDfan closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants