Skip to content

Docs update #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MagicLike merged 5 commits into from
Sep 21, 2023
Merged

Docs update #21

MagicLike merged 5 commits into from
Sep 21, 2023

Conversation

@MagicLike
Copy link
Member

@MagicLike MagicLike commented Sep 17, 2023 •
edited
Loading

@MagicLike MagicLike added the documentation Improvements or additions to documentation label Sep 17, 2023
@MagicLike MagicLike requested a review from tsterbak September 17, 2023 16:30
@MagicLike MagicLike self-assigned this Sep 17, 2023
@MagicLike MagicLike mentioned this pull request Sep 17, 2023
Merged
6 tasks
tsterbak
tsterbak approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@tsterbak tsterbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) I move forward and do the merges.

@MagicLike MagicLike changed the base branch from main to page-updates September 21, 2023 17:10
@MagicLike
Copy link
Member Author

MagicLike commented Sep 21, 2023 •
edited
Loading

Looks good to me :) I move forward and do the merges.

I'd merge this one into page-updates first - if that's fine...

Edit: @tsterbak Because of conflicts I needed to merge into #22... The good thing: I am also almost finished with that one, so that it can be merged with the new OAI release! The only thing that is missing, is a SVG of the OAI JPEG - see #16 (comment)

@MagicLike MagicLike merged commit a18a12e into page-updates Sep 21, 2023
@tsterbak
Copy link
Member

tsterbak commented Sep 22, 2023

Edit: @tsterbak Because of conflicts I needed to merge into #22... The good thing: I am also almost finished with that one, so that it can be merged with the new OAI release! The only thing that is missing, is a SVG of the OAI JPEG - see #16 (comment)

That will be a bit annoying, and I would have preferred to keep changes necessary for the release separate from other changes. But let's see how it goes.

@MagicLike
Copy link
Member Author

MagicLike commented Sep 22, 2023

Edit: @tsterbak Because of conflicts I needed to merge into #22... The good thing: I am also almost finished with that one, so that it can be merged with the new OAI release! The only thing that is missing, is a SVG of the OAI JPEG - see #16 (comment)

That will be a bit annoying, and I would have preferred to keep changes necessary for the release separate from other changes. But let's see how it goes.

Also not my favourite choice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsterbak tsterbak tsterbak approved these changes

Assignees

@MagicLike MagicLike

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MagicLike @tsterbak