Skip to content

Conversation

@Angus-repo
Copy link
Contributor

@Angus-repo Angus-repo commented Jul 28, 2025

This document is the description for nightscout/AndroidAPS#3921. Please review it.

aaps-ci-preview

@psonnera
Copy link
Collaborator

I believe this has already been discussed in Discord and can't merge it without authorization. https://discord.com/channels/629952586895851530/817392867995680768/1144027007756292186

@Angus-repo
Copy link
Contributor Author

Hello,
Understood. Please wait a little longer — MilosKozak is likely still evaluating it. If it turns out to be unsuitable in the end, I will close this PR.

@psonnera
Copy link
Collaborator

psonnera commented Aug 1, 2025

Excellent, I keep it open. Thanks.

@psonnera psonnera requested a review from MilosKozak August 1, 2025 19:47
@MilosKozak
Copy link
Collaborator

can you include html file to this PR? @Angus-repo

@Angus-repo Angus-repo force-pushed the aaps-ci branch 2 times, most recently from b77574b to 6df88b4 Compare August 6, 2025 10:25
@MilosKozak
Copy link
Collaborator

the link is wrong now

@Angus-repo
Copy link
Contributor Author

Hello,
I have added aaps-ci-preparation.html to the PR. It can be downloaded from the wiki. Please review.
BuildingAaps.html

@psonnera
Copy link
Collaborator

psonnera commented Aug 9, 2025

@Angus-repo great doc and videos. Couple of gaps: most users don't have a fork of the main repo, I'll add instructions on how to fork and update. Links will have to be updated as it's not clear which URL you need to download the html (for now your repo). I will also try to get the jks java generator into readthedocs (did you try?).

@Angus-repo
Copy link
Contributor Author

Angus-repo commented Aug 10, 2025

Thank you, psonnera, for the reminder.
The method for obtaining the GitHub repository has changed, and indeed it should be explained.

I will first add the prerequisites, and then you can check if anything else needs to be supplemented.
BuildingAaps.html

Once it is officially merged into the main repository (master branch), it will only be necessary to fork from the main repo.

Currently, the preview aaps-ci (readthedocs) already includes the download link for aaps-ci-preparation.html, which contains the JKS generation. This JKS is compatible with the information required for building the APK, so there’s no need to include a separate Java JKS anymore.

Screenshot_20250810_144614~2.jpg

@psonnera
Copy link
Collaborator

@Angus-repo please have a look at the test page https://androidaps.readthedocs.io/en/latest/SettingUpAaps/BrowserBuild.html (not linked to the menu) and continue PRs on it. I copied the files and contents from your PR and added some steps for non-techs. Free to chat on Discord, Facebook or here. Thank you.

@psonnera
Copy link
Collaborator

@Angus-repo and now I see you did more in the meantime. Sorry for the interference...

@Angus-repo
Copy link
Contributor Author

Angus-repo commented Aug 11, 2025

@psonnera , thank you. I will close this PR, and for future modifications to BrowserBuild, I will submit a separate PR. Thanks.

@Angus-repo Angus-repo closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants