Skip to content

Bug/connection to the broker closed #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aspirio187 merged 7 commits into from
Jun 20, 2022
Merged

Bug/connection to the broker closed #22

aspirio187 merged 7 commits into from
Jun 20, 2022

Conversation

@aspirio187
Copy link
Collaborator

@aspirio187 aspirio187 commented Jun 20, 2022

Description

When the AMQP connection is closed (intentionnally or by a bug/mistake), the program will try to reconnect every 5 seconds until it is stopped.

A bug throwing an exception when closing a dossier has been fixed too.

Fixes #16

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been

Tests were done manually, meaning one with a docker-compose restart and one with docker-compose stop and docker-compose start after a few moment. Both were successful

  • Restart container
  • Stop container and start it back after a moment

Test Configuration:

  • Firmware version:
  • Hardware:
  • Operating System: Ubuntu 22.04 LTS
  • Toolchain: VsCode
  • SDK: .NET 6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@aspirio187 aspirio187 added the bug Something isn't working label Jun 20, 2022
@aspirio187 aspirio187 requested a review from nbittich June 20, 2022 11:52
nbittich
nbittich approved these changes Jun 20, 2022
View reviewed changes
@aspirio187 aspirio187 merged commit ca2c70f into develop Jun 20, 2022
@aspirio187 aspirio187 deleted the bug/connection-to-the-broker-closed branch June 20, 2022 12:50
nbittich pushed a commit that referenced this pull request Jul 18, 2022
@aspirio187 @nbittich
Bug/connection to the broker closed (#22)
96a20eb 
* cleaned code

* reconnect after amqp connection failed or closed

* fixed dossier close exception

* cleaned reconnection attempt

* fixed message nb parameters

* reset the connection attempts once it is connected

* removed the connection attempts verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbittich nbittich nbittich approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Connection to the broker closed!

3 participants

@aspirio187 @nbittich