Skip to content

scripts/openbabel-python.i: Revert shared_ptr changes#41

Merged
ghutchis merged 1 commit intoopenbabel:masterfrom
Reinis:revert_shared_ptr_in_py
Nov 22, 2013
Merged

scripts/openbabel-python.i: Revert shared_ptr changes#41
ghutchis merged 1 commit intoopenbabel:masterfrom
Reinis:revert_shared_ptr_in_py

Conversation

@Reinis
Copy link
Copy Markdown
Contributor

@Reinis Reinis commented Nov 21, 2013

This reverts part of ce178cb.

@Reinis
Copy link
Copy Markdown
Contributor Author

Reinis commented Nov 21, 2013

Fixes regression:

~$ python
Python 3.3.2 (default, Nov 21 2013, 05:56:52) 
[GCC 4.8.2] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import openbabel as ob
>>> m = ob.OBMol()
>>> m += ob.OBMol()
>>> m += ob.OBMol()
Segmentation fault

ghutchis added a commit that referenced this pull request Nov 22, 2013
scripts/openbabel-python.i: Revert shared_ptr changes
@ghutchis ghutchis merged commit 54520d4 into openbabel:master Nov 22, 2013
@ghutchis
Copy link
Copy Markdown
Member

I'd like a more permanent solution, but I agree with this. (The Python bindings would not compile on Mac before this change.)

@Reinis Reinis deleted the revert_shared_ptr_in_py branch November 22, 2013 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants