Feature: add GitHub workflows to build docker containers#13
Merged
reinauer merged 3 commits intoopenbios:masterfrom Feb 15, 2022
Merged
Feature: add GitHub workflows to build docker containers#13reinauer merged 3 commits intoopenbios:masterfrom
reinauer merged 3 commits intoopenbios:masterfrom
Conversation
This introduces a new Dockerfile.builder file that can be used by docker build to generate a container that can build fcode-utils based upon Debian 11.2. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
This is a GitHub manual action that generates a container image from docker/Dockerfile.builder and pushes the result to ghcr.io/openbios/fcode-utils-builder:master for public use. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
This is a GitHub push action that generates a container image from docker/Dockerfile using the fcode-utils-builder image and pushes the result to ghcr.io/openbios/fcode-utils:master for public use. It is essentially a standard Debian 11.2 image with the binaries copied into /usr/bin. Note that this action also creates a zip artifact containing the binaries and localvariables directories to allow simple build testing and verification upon merge. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Collaborator
Author
Member
|
Great work! There is also a test suite in fcode-utils, but last I tried to get it working on my x86-64 Linux box it was not a pretty sight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a pre-requisite for an upcoming set of changes to introduce GitHub workflows for building OpenBIOS. It essentially creates 2 separate images and makes them publically available in the Packages tab for the openbios organisation:
ghcr.io/openbios/fcode-utils-builder:master: a builder image based upon Debian 11.2 containing all of the tools required to build the fcode-utils repositoryghcr.io/openbios/fcode-utils:master: a standard Debian 11.2 image containing the fcode-utils binaries installed in /usr/binThe workflows are defined so that they can be manually triggered from the Actions tab by an administrator, and also in the case of a push or merge the existing fcode-utils-builder image is used to generate updated binaries in both the public fcode-utils image and a separate zip artifact.
For examples of how this looks please see my repository at https://github.com/mcayland. Note that last build fails because I changed the workflows to use the images hosted by the openbios organisation rather than myself.