Skip to content

Add clear table selection method#238

Merged
neon-balcony merged 2 commits intoopenblocks-dev:developfrom
ronen770:develop
Feb 8, 2023
Merged

Add clear table selection method#238
neon-balcony merged 2 commits intoopenblocks-dev:developfrom
ronen770:develop

Conversation

@ronen770
Copy link
Copy Markdown
Contributor

@ronen770 ronen770 commented Feb 4, 2023

Allow to programmatically clear table rows selected. Such as #214

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 4, 2023

CLA assistant check
All committers have signed the CLA.

},
{
method:{
name: "clearSelections",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method reset the selection to the default value, so it better rename to "resetSelections"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed the method name

params: [],
},
execute: (comp) => {
comp.children.selection.children.selectedRowKey.dispatchChangeValueAction("0");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or change the value to an empty string if you want to clear the selection.

@neon-balcony
Copy link
Copy Markdown
Contributor

Hey @ronen770, thanks very much for the PR! Would you please sign the above Contributor License Agreement so that we can merge your PR?
image

@neon-balcony neon-balcony merged commit 076a934 into openblocks-dev:develop Feb 8, 2023
@neon-balcony
Copy link
Copy Markdown
Contributor

PR merged, thanks again for the submission! 😄 @ronen770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants