fix(validation): allow + in package names (e.g. logi-options+)#10
Merged
Conversation
Real Homebrew casks contain +, so the publish API was rejecting valid configs. + is not a shell metacharacter, so allowing it doesn't widen the injection surface guarded by existing tests. Fixes #101 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+character in package names so casks likelogi-options+and formulae likegtk+can be publishedFixes openbootdotdev/openboot#101
Why
Real Homebrew casks contain
+, so the publish API was rejecting valid configs withInvalid package name at index N: "logi-options+".+is not a shell metacharacter (no substitution, redirection, piping, or backgrounding), so allowing it doesn't widen the shell-injection surface — existing tests for;,|,`,$,&&,>, and newline still reject those.Test plan
npx vitest run src/lib/server/validation.test.ts— 64/64 pass, including new test forlogi-options+andgtk+npm run lint— no new errorsopenboot snapshot --publishwith a cask whose name contains+succeedsNote
The CLI (Go) likely has a mirror of this regex per the
validateMacOSPrefsconvention comment. May need a matching fix there if CLI-side rejects before upload in some flow.🤖 Generated with Claude Code