Skip to content

feat(snapshot): accept bun globals from CLI publish payload #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fullstackjam merged 1 commit into from
Jun 6, 2026
Merged

feat(snapshot): accept bun globals from CLI publish payload #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/routes/api/configs/from-snapshot/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const POST: RequestHandler = async ({ platform, cookies, request }) => {
const base_preset = snapshot.matched_preset || 'developer';

// Validate snapshot.packages is the canonical structured format:
// { formulae: string[], casks: string[], taps: string[], npm: string[] }
// { formulae: string[], casks: string[], taps: string[], npm: string[], bun?: string[] }
if (!snapshot.packages || typeof snapshot.packages !== 'object' || Array.isArray(snapshot.packages)) {
return json({ error: 'snapshot.packages must be an object with formulae, casks, taps, npm arrays' }, { status: 400 });
}
Expand All @@ -66,6 +66,7 @@ export const POST: RequestHandler = async ({ platform, cookies, request }) => {
const snapshotFormulae: string[] = snapshot.packages?.formulae || [];
const snapshotCasks: string[] = snapshot.packages?.casks || [];
const snapshotNpm: string[] = snapshot.packages?.npm || [];
const snapshotBun: string[] = snapshot.packages?.bun || [];
const snapshotTaps: string[] = snapshot.packages?.taps || [];

// Build a set of formula names that are already covered by a tap entry
Expand All @@ -81,12 +82,20 @@ export const POST: RequestHandler = async ({ platform, cookies, request }) => {
}
}

// Bun globals come from the npm registry and install fine via `npm install -g`,
// so we bucket them with npm in the typed `packages` array (the canonical
// downstream schema only special-cases `npm` and `cask`). Bun provenance is
// still preserved in the raw `snapshot.packages.bun` blob for future use.
const npmSet = new Set(snapshotNpm);
const bunAsNpm = snapshotBun.filter((name) => !npmSet.has(name));

const packages = [
...snapshotFormulae
.filter((name) => !tapFormulaNames.has(name))
.map((name) => ({ name, type: 'formula' })),
...snapshotCasks.map((name) => ({ name, type: 'cask' })),
...snapshotNpm.map((name) => ({ name, type: 'npm' })),
...bunAsNpm.map((name) => ({ name, type: 'npm' })),
...snapshotTaps.map((name) => ({ name, type: 'tap' })),
];

Expand Down
Loading