fix(config): allow '+' in package and cask names#102
Merged
Conversation
Homebrew casks like `logi-options+` and formulae like `gtk+` legitimately contain '+', but pkgNameRe rejected them — causing `snapshot --publish` to fail at the server boundary with a 400. Fixes #101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+topkgNameReso Homebrew casks likelogi-options+and formulae likegtk+validate.TestRemoteConfig_AllowsPlusInPackageNames).Without this,
openboot snapshot --publishfails for users whose machine has any cask containing+. The server returns a 400 (Only alphanumeric, hyphens, underscores, dots, @ and / allowed.), but the CLI's own regex is identical — so the same input would be rejected once client-side validation is wired in too.Server-side validation needs the matching relaxation in a separate PR on the openboot.dev repo.
Fixes #101
Test plan
go test -run TestRemoteConfig_AllowsPlusInPackageNames ./internal/config/— failed before the regex change, passes after.make test-unit— full L1 green.go vet ./...