Remove quality scorecard script and related make targets#28
Merged
fullstackjam merged 1 commit intomainfrom Apr 19, 2026
Merged
Remove quality scorecard script and related make targets#28fullstackjam merged 1 commit intomainfrom
fullstackjam merged 1 commit intomainfrom
Conversation
The quality/ scorecard output and scripts/quality-score.sh are one-off artifacts. The Makefile's quality-lint target duplicates what CI already runs via golangci-lint-action, and quality-security runs gosec which is already enabled as a linter in .golangci.yml.
|
👋 Thanks for opening this pull request! Before merging:
@fullstackjam will review this soon. Thanks for contributing! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
scripts/quality-score.shscript, the generatedquality/score.jsonfile, and the associatedquality-lintandquality-securitymake targets.Why?
The quality scorecard script and its generated output appear to be unused or superseded by other quality assurance mechanisms. Removing these artifacts simplifies the build system and reduces maintenance overhead.
Testing
N/A — This is a removal of unused tooling with no impact on core functionality.
Notes for reviewer
quality-score.shscript was a comprehensive quality metrics runner that evaluated test coverage, lint errors, security issues, complexity, and file sizequality/score.jsonfile was its generated output artifactquality-lintandquality-securitymake targets were convenience wrappers aroundgolangci-lintandgosechttps://claude.ai/code/session_01D7sqgEbaGcZ1LTi9xbM8sA