Skip to content

fix(ui): use tabStyle for inactive tabs to resolve unused var lint error#50

Merged
fullstackjam merged 1 commit intomainfrom
claude/vigorous-ardinghelli-bc3a62
Apr 22, 2026
Merged

fix(ui): use tabStyle for inactive tabs to resolve unused var lint error#50
fullstackjam merged 1 commit intomainfrom
claude/vigorous-ardinghelli-bc3a62

Conversation

@fullstackjam
Copy link
Copy Markdown
Collaborator

Summary

  • tabStyle was declared in selector_view.go but never used, causing golangci-lint to fail
  • renderTabBar() was creating an inline neighborStyle (same #666 colour) instead of using the package-level var
  • Replace the inline local with tabStyle to remove the duplication and satisfy the linter

Test plan

  • go vet ./internal/ui/... passes
  • Lint CI job passes

@github-actions github-actions Bot added the ui Terminal UI label Apr 22, 2026
@github-actions
Copy link
Copy Markdown

👋 Thanks for opening this pull request!

Before merging:

  • Code follows existing patterns in the codebase
  • go build ./... and go vet ./... pass
  • Commit message is clear and descriptive

@fullstackjam will review this soon. Thanks for contributing! 🚀

@fullstackjam fullstackjam merged commit 4f88e38 into main Apr 22, 2026
9 checks passed
@fullstackjam fullstackjam deleted the claude/vigorous-ardinghelli-bc3a62 branch April 22, 2026 15:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/ui/selector_view.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Terminal UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant