docs(install): clarify --silent help text and field comment#79
Merged
Conversation
The flag help said "for CI/CD", but actual usage is e2e tests (bubbletea can't drive in a Tart VM without a PTY) and scripts/install.sh; real CI doesn't run `openboot install`. Updates the help string and the matching struct field comment to describe what the mode actually does.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--silentaretest/e2e/*(Tart VM, no PTY) andscripts/install.sh's curl|bash example. Real CI (GitHub Actions) never runsopenboot install.internal/cli/install.gohelp text + matchingSilentfield comment ininternal/config/types.goto describe what the mode actually does.--silent) is unchanged — renaming would be breaking for users' scripts / dotfiles / MDM payloads.Test plan
go vet ./internal/cli/... ./internal/config/...clean