chore: remove dead code and fix deadcode harness tag#87
Merged
Conversation
- testutil: delete IsPackageInstalled, UninstallPackage, EnsurePackageNotInstalled (callers were in real_install_test.go which was removed earlier) - testutil: delete MacHost.Destroy (no-op, never called) - test/e2e: delete vmInstallViaBrewTap, vmRunOpenbootWithGit, vmWriteTestSnapshot (became dead after FirstTimeUser switched to dev binary + snapshot tests removed) - harness.yml: run deadcode with -tags="e2e,vm" so test helpers with e2e-only callers (BuildTestBinary etc.) are not falsely flagged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsPackageInstalled,UninstallPackage,EnsurePackageNotInstalledfromtestutil/helpers.go— callers were inreal_install_test.gowhich was removed in ci: move L4 vm-e2e from tart to github actions macos-14 #86MacHost.Destroy— no-op method, never calledvmInstallViaBrewTap,vmRunOpenbootWithGit,vmWriteTestSnapshotfromtest/e2e/vm_helpers_test.go— became dead after ci: move L4 vm-e2e from tart to github actions macos-14 #86 switched to dev binary and removed snapshot testsharness.yml: rundeadcodewith-tags="e2e,vm"so helpers only called from e2e-tagged files (e.g.BuildTestBinary) are not falsely flagged as deadTest plan
deadcode -test -tags="e2e,vm" ./...returns clean locallygo vet ./...cleango build ./...clean