fix(test): correct brew tap name in vmInstallViaBrew#93
Merged
Conversation
…bootdotdev/tap brew tap user/foo maps to github.com/user/homebrew-foo; the actual repo is openbootdotdev/homebrew-tap so the correct tap is openbootdotdev/tap. This was silently failing (|| true) causing TestVM_Interactive_InstallScript to always skip since brew info openboot never found the formula.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vmInstallViaBrewwas tappingopenbootdotdev/openbootwhich maps togithub.com/openbootdotdev/homebrew-openboot— that repo doesn't exist. The actual tap isopenbootdotdev/tap(maps togithub.com/openbootdotdev/homebrew-tap).The
|| truesilenced the failure, sobrew install openbootthen failed with "No available formula". This is whyTestVM_Interactive_InstallScriptwas always skipping — the old guard checkedbrew info openbootwhich never found the formula because the tap never actually loaded.Test plan
vm-e2e-spikeand confirmTestVM_Interactive_InstallScriptruns (not SKIP, not FAIL)