Skip to content

Validate types in SimulationExecutionFilter and ElectricalRecordingStimulusFilter #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GianlucaFicarelli merged 1 commit into from
Sep 17, 2025
Merged

Validate types in SimulationExecutionFilter and ElectricalRecordingStimulusFilter #369

GianlucaFicarelli merged 1 commit into from
Sep 17, 2025

Conversation

@GianlucaFicarelli
Copy link
Collaborator

@GianlucaFicarelli GianlucaFicarelli commented Sep 17, 2025

No description provided.

@GianlucaFicarelli GianlucaFicarelli self-assigned this Sep 17, 2025
@codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 96.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/filters/electrical_recording_stimulus.py 100.00% <100.00%> (ø)
app/filters/simulation_execution.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mgeplf
mgeplf reviewed Sep 17, 2025
View reviewed changes
@GianlucaFicarelli GianlucaFicarelli merged commit 3ceb936 into main Sep 17, 2025
2 checks passed
@GianlucaFicarelli GianlucaFicarelli deleted the enforce_type_in_filters branch September 17, 2025 08:37
@GianlucaFicarelli GianlucaFicarelli added this to the 2025.9.6 milestone Sep 17, 2025
GianlucaFicarelli added a commit that referenced this pull request Sep 17, 2025
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into draft-into-morphology…
3d5e5fe 
…-model

* origin/main:
  Validate types in SimulationExecutionFilter and ElectricalRecordingStimulusFilter (#369)
  Semantic search with pgvector (#340)
GianlucaFicarelli added a commit that referenced this pull request Sep 23, 2025
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into notebook_entities_v2
59aaa6f 
* origin/main:
  Add update endpoints for service admins (#355)
  Add read endpoints for service admins (#354)
  Validate types in SimulationExecutionFilter and ElectricalRecordingStimulusFilter (#369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgeplf mgeplf mgeplf approved these changes

@bilalesi bilalesi bilalesi approved these changes

@eleftherioszisis eleftherioszisis eleftherioszisis approved these changes

@juanjosegarcan juanjosegarcan Awaiting requested review from juanjosegarcan

Assignees

@GianlucaFicarelli GianlucaFicarelli

Labels

None yet

Projects

None yet

Milestone

2025.9.6

Development

Successfully merging this pull request may close these issues.

5 participants

@GianlucaFicarelli @bilalesi @mgeplf @eleftherioszisis