Add delete endpoints for users#379
Merged
eleftherioszisis merged 8 commits intomainfrom Sep 29, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
4840c84 to
ecd86a8
Compare
ecd86a8 to
488d50f
Compare
4 tasks
| db: SessionDep, | ||
| id_: uuid.UUID, | ||
| user_context: AdminContextDep, # noqa: ARG001 | ||
| ): |
Collaborator
There was a problem hiding this comment.
The type annotation is missing in some of the delete_one endpoints.
Instead of a generic dict, it would be better if we define a proper schema, so that it's displayed in the openapi docs.
488d50f to
2cc6b83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_project_idsare taken into account (i.e. project_id in the header is ignored)