Skip to content

Remove nested filters in NestedCellMorphologyFilter#550

Merged
GianlucaFicarelli merged 1 commit intomainfrom
remove_nested_NestedCellMorphologyFilter
Mar 9, 2026
Merged

Remove nested filters in NestedCellMorphologyFilter#550
GianlucaFicarelli merged 1 commit intomainfrom
remove_nested_NestedCellMorphologyFilter

Conversation

@GianlucaFicarelli
Copy link
Collaborator

@GianlucaFicarelli GianlucaFicarelli commented Mar 9, 2026

Remove nested filters used in emodel.exemplar_morphology and memodel.morphology, since they aren't used and they cannot work unless the query is modified by adding joined tables.

Note also that the filters aren't very useful for emodel.exemplar_morphology since it's returned by the read_many endpoints in:

and exemplar_morphology is a subclass of CellMorphologyBase, that doesn't contain brain_region, subject, mtype:

class CellMorphologyBase(BaseModel, NameDescriptionMixin):

Instead, memodel.morphology defined in:

is a subclass of CellMorphologyRead and it contains all the nested brain_region, subject, mtype, but these values aren't shown in the list view in the UI

@GianlucaFicarelli GianlucaFicarelli self-assigned this Mar 9, 2026
@GianlucaFicarelli GianlucaFicarelli force-pushed the remove_nested_NestedCellMorphologyFilter branch from 0f9c8f5 to efe2704 Compare March 9, 2026 06:50
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 97.91% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/filters/cell_morphology.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from filter_has_segmented_spines to main March 9, 2026 07:39
@GianlucaFicarelli GianlucaFicarelli marked this pull request as ready for review March 9, 2026 09:41
@GianlucaFicarelli GianlucaFicarelli force-pushed the remove_nested_NestedCellMorphologyFilter branch from efe2704 to 8937859 Compare March 9, 2026 09:42
@GianlucaFicarelli GianlucaFicarelli merged commit 3427b28 into main Mar 9, 2026
2 checks passed
@GianlucaFicarelli GianlucaFicarelli deleted the remove_nested_NestedCellMorphologyFilter branch March 9, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants