Remove nested filters in NestedCellMorphologyFilter#550
Merged
GianlucaFicarelli merged 1 commit intomainfrom Mar 9, 2026
Merged
Remove nested filters in NestedCellMorphologyFilter#550GianlucaFicarelli merged 1 commit intomainfrom
GianlucaFicarelli merged 1 commit intomainfrom
Conversation
0f9c8f5 to
efe2704
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
efe2704 to
8937859
Compare
eleftherioszisis
approved these changes
Mar 9, 2026
mgeplf
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove nested filters used in emodel.exemplar_morphology and memodel.morphology, since they aren't used and they cannot work unless the query is modified by adding joined tables.
Note also that the filters aren't very useful for
emodel.exemplar_morphologysince it's returned by the read_many endpoints in:entitycore/app/schemas/emodel.py
Line 71 in 2259a9c
and exemplar_morphology is a subclass of CellMorphologyBase, that doesn't contain brain_region, subject, mtype:
entitycore/app/schemas/cell_morphology.py
Line 17 in 2259a9c
Instead,
memodel.morphologydefined in:entitycore/app/schemas/me_model.py
Line 67 in 2259a9c
is a subclass of CellMorphologyRead and it contains all the nested brain_region, subject, mtype, but these values aren't shown in the list view in the UI