fix(#633): handle invalid UUIDs in found_by parameter#634
Merged
deg-pl merged 2 commits intoopencaching:masterfrom Dec 10, 2024
Merged
fix(#633): handle invalid UUIDs in found_by parameter#634deg-pl merged 2 commits intoopencaching:masterfrom
deg-pl merged 2 commits intoopencaching:masterfrom
Conversation
wrygiel
approved these changes
Nov 21, 2024
Member
wrygiel
left a comment
wrygiel
left a comment
There was a problem hiding this comment.
Thanks for the fix! This looks good to me (apart from some details mentioned in the review). However, I no longer actively maintain OKAPI, so I suggest you wait at least one day before merging (perhaps there are other, more active reviewers who'd want to chip in).
| try { | ||
| $users = OkapiServiceRunner::call("services/users/users", new OkapiInternalRequest( | ||
| $this->request->consumer, null, array('user_uuids' => $tmp, 'fields' => 'internal_id'))); | ||
| if (empty($users) || !is_array($users)) { |
Member
There was a problem hiding this comment.
This should be outside (below) the surrounding try..catch.
| "The following UUID(s) are invalid or not found: " . implode(", ", $invalid_uuids) | ||
| ); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Indent with spaces (match the existing indentation).
Author
|
It would be best if the fix waited for merging at least until Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.