Metrics Deployment#401
Merged
Merged
Conversation
… metrics deployment
Contributor
✅ All pre-commit checks passedThanks for keeping the repo tidy! ✨ |
at88mph
requested changes
May 5, 2026
Address PR review: cluster-scoped RBAC is controlled by an explicit metrics-backend.rbac.create knob (default true), matching the session limit range pattern. metrics-backend.enabled continues to gate the metrics Deployment and Service.
Opt out of cluster-scoped RBAC unless GitOps sets rbac.create: true.
Undo default-false rbac; keep gated by enabled and rbac.create.
- Rename values key from metrics-backend to metricsBackend; drop rbac.create - Replace template files with metricsBackend-*.yaml naming - Document RBAC-before-workload Helm kind ordering for fail-fast installs - Rename helm test Pod to *-metrics-backend-test (DNS-safe)
Move metricsBackend install-ordering prose after chart.valuesSection in README.md.gotmpl so helm-docs regeneration preserves it.
at88mph
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.