cadc-tap-server: use explicit long and double format objects#232
Merged
pdowler merged 1 commit intoopencadc:mainfrom Nov 25, 2025
Merged
cadc-tap-server: use explicit long and double format objects#232pdowler merged 1 commit intoopencadc:mainfrom
pdowler merged 1 commit intoopencadc:mainfrom
Conversation
to extract values from jdbc driver
aratikakadiya
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to extract values from jdbc driver
reason: if the select list in a query contains expressions (algebraic, case statements, etc) it is not possible to infer the right type, but valuable to get close, so the ADQL parser infers
longordoublewhen it can... however, the jdbc driver's ResultSet.getObject might return something different (Integer instead of Long) and cause a ClassCastException when the TableWriter tries to write the value!So this just makes sure that long and double (from ADQL type inference) will extract the right types. As a aside efefct, it will hide a mismatch between the database and tap_schema in cases (eg database uses int but tap_schema says long).