Conversation
…tdown callbacks Problem: When AndroidAutoEntity::stop() called messenger_->stop(), only the message queue was cleared but pending receive/send promises remained active. This caused a flood of channel error callbacks (AASDK Error: 30) when the transport closed, leading to re-entrant teardown attempts and potential application freezes. Solution: - Messenger::stop() now rejects all pending receive promises with OPERATION_ABORTED - Messenger::stop() now rejects all pending send promises with OPERATION_ABORTED - Both operations are dispatched on their respective strands to ensure thread safety Impact: - Services will now receive OPERATION_ABORTED errors during shutdown (expected) - Prevents spurious channel errors after messenger is stopped - Enables clean, deterministic shutdown without callback floods - Applications should handle OPERATION_ABORTED as a normal shutdown signal This is the library-level fix for clean async operation cancellation during teardown. Application-level services should treat OPERATION_ABORTED as debug-level logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Messenger::stop() to reject pending promises and prevent post-shutdown callbacks
Problem:
When AndroidAutoEntity::stop() called messenger_->stop(), only the message queue was cleared but pending receive/send promises remained active. This caused a flood of channel error callbacks (AASDK Error: 30) when the transport closed, leading to re-entrant teardown attempts and potential application freezes.
Solution:
Impact:
This is the library-level fix for clean async operation cancellation during teardown. Application-level services should treat OPERATION_ABORTED as debug-level logging.