Reduce duplicate code for NavBar components#1017
Conversation
This patch attempts to reduce duplicate code by moving components that would usually be passed to the NavBar component INTO the NavBar component. This does come with the trade-off that the NavBar component is now less general. However, as it is the NavBar component was pretty pointless anyway so this should not be an issue.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1017/2025-02-11_09-03-16/ . |
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
reduce-duplicate-code-navigation
branch
from
e29fb28 to
0bfa3e4
Compare
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
As far as I can tell, there are no functional changes, so it behaves as described and expected. Code looks reasonable (Maybe you could factor out some more stuff, but this is already a good improvement and enough for now imo).
2 participants
This patch attempts to reduce duplicate code by moving components that would usually be passed to the NavBar component INTO the NavBar component.
This does come with the trade-off that the NavBar component is now less general. However, as it is the NavBar component was pretty pointless anyway so this should not be an issue.
This is the "NavBar":
How to test this
Can be tested as usual, no configuration or Opencast patch necessary. There should be no functional changes, so the main thing to test here is that everything behaves as usual.