Skip to content

Reduce duplicate code in action cells#1018

Merged
Arnei merged 3 commits intoopencast:mainfrom
Arnei:reduce-duplicate-code-actioncell
Feb 11, 2025
Merged

Reduce duplicate code in action cells#1018
Arnei merged 3 commits intoopencast:mainfrom
Arnei:reduce-duplicate-code-actioncell

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Dec 17, 2024

Mostly by turning the button that's copy-pasted everywhere into its own component.

These are the "action cells":
Bildschirmfoto vom 2024-12-17 17-38-56

How to test this

Can be tested as usual, no configuration or Opencast patch necessary. There should be no functional changes, so the main thing to test here is that everything behaves as usual.

@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Dec 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1018

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1018

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 17, 2024

This pull request is deployed at test.admin-interface.opencast.org/1018/2025-01-31_15-15-29/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Mostly by turning the button that's copy-pasted
everywhere into its own component.
@Arnei Arnei force-pushed the reduce-duplicate-code-actioncell branch from 5c88e41 to c41ca77 Compare January 17, 2025 13:06
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Copy Markdown
Contributor

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, everything's still working.

@Arnei Arnei merged commit edbcbec into opencast:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:code-enhancement Internal improvements to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants