Skip to content

Fix date not rendering in scheduling tab#1019

Merged
gregorydlogan merged 2 commits intoopencast:mainfrom
Arnei:fix-date-in-event-details-scheduling-tab
Jan 16, 2025
Merged

Fix date not rendering in scheduling tab#1019
gregorydlogan merged 2 commits intoopencast:mainfrom
Arnei:fix-date-in-event-details-scheduling-tab

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Dec 18, 2024

Fixes #1005.

The date was not rendering the event details scheduling tab. This patch fixes that.

How to test this

Can be tested as usual, no configuration or Opencast patch necessary. To test, follow the steps in the linked issue and check if the issue is resolved.

The date was not rendering the event details
scheduling tab. This patch fixes that.
@Arnei Arnei added the type:bug Something isn't working label Dec 18, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2024

This pull request is deployed at test.admin-interface.opencast.org/1019/2025-01-06_11-02-00/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1019

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1019

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@gregorydlogan gregorydlogan self-assigned this Jan 16, 2025
@gregorydlogan gregorydlogan merged commit 34e0c7a into opencast:main Jan 16, 2025
@marcusm7
Copy link
Copy Markdown

https://test.admin-interface.opencast.org/1019/2025-01-06_11-02-00/

When I open the page the date picker for the start date is already openened (firefox 134 in wayland). Is this a side effect in the test-mockup or a bug?

image

@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Jan 17, 2025

I can reproduce that behaviour on the main branch, but only if I had that specific date picker open before reloading the page. I cannot reproduce it any other way.

Still, this is technically a bug. Want to open an issue for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues of the date field in the scheduling tab of the event properties

3 participants