Skip to content

Fix metadata fields not editable during multi edit#1041

Merged
Arnei merged 3 commits intoopencast:mainfrom
Arnei:edit-multifields-in-editmultipleeventsmodal
Jan 31, 2025
Merged

Fix metadata fields not editable during multi edit#1041
Arnei merged 3 commits intoopencast:mainfrom
Arnei:edit-multifields-in-editmultipleeventsmodal

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Jan 3, 2025

In the modal for editing multiple events at the same time, the fields "presenter(s)" and "contributor(s)" were not editable in some cases. This patch fixes that.

How to test this

This patch should ideally be tested with a production Opencast. Unfortunately, I do not actually know what the exact Opencast configuration is that causes the error this patch this is supposed to fix. The modal for editing multiple events can be found in the events table next to the search bar and filters.

@Arnei Arnei added the type:bug Something isn't working label Jan 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 3, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1041

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1041

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 3, 2025

This pull request is deployed at test.admin-interface.opencast.org/1041/2025-01-31_11-09-44/ .
It might take a few minutes for it to become available.

In the modal for editing multiple events at the same time,
the fields "presenter(s)" and "contributor(s)"
were not editable in some cases. This patch fixes that.
@Arnei Arnei force-pushed the edit-multifields-in-editmultipleeventsmodal branch from 0af864d to 8a91398 Compare January 3, 2025 14:31
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Copy Markdown
Contributor

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a trick in reproducing the bug? I didn't notice any issues either on main or this branch, but the code looks reasonable.

I did notice however that clicking the start date field when editing multiple events crashes the app. This is also the case on main, so you don't necessarily need to fix it here, but it would be fitting I suppose.
So if you don't want to do that, consider this approved.

@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Jan 31, 2025

Is there a trick in reproducing the bug?

Likely, but I unfortunately do not know it. I developed this against the Opencast of one of our clients, but was unable to determine which change in their configuration was responsible.

I did notice however that clicking the start date field when editing multiple events crashes the app. This is also the case on main, so you don't necessarily need to fix it here, but it would be fitting I suppose.

I'd prefer handling that in a separate PR. Would you open an issue for it?

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei merged commit 7f69bdb into opencast:main Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants