Skip to content

Clear modal notifs when opening modal#1051

Merged
Arnei merged 7 commits intoopencast:mainfrom
Arnei:properly-clear-modal-notifications
Jan 31, 2025
Merged

Clear modal notifs when opening modal#1051
Arnei merged 7 commits intoopencast:mainfrom
Arnei:properly-clear-modal-notifications

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Jan 10, 2025

When opening a modal, modal notifications were not properly cleared. This would lead to notifications being displayed in the wrong modals, i.e. "This event cannot be edited due to an active workflow" would appear on a create series modal. This patch should fix that.

Includes #1021.

How to test this

Can be tested as usual. Trigger a warning in one modal and check if it appears in different modals.

When opening a modal, modal notifications were
not properly cleared. This would lead to notifications
being displayed in the wrong modals, i.e. "This
event cannot be edited due to an active workflow"
would appear on a create series modal.
This patch should fix that.
@Arnei Arnei added the type:bug Something isn't working label Jan 10, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1051

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1051

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 10, 2025

This pull request is deployed at test.admin-interface.opencast.org/1051/2025-01-31_14-08-50/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Copy Markdown
Contributor

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does what is described. Since #1021 is included here, my comment from there regarding the Tobira notif applies to this as well.
I suppose that other PR can be closed. It's up to you whether you want to remove the empty then()s here as well.

@Arnei Arnei merged commit a5f60fa into opencast:main Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants